Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix isSelfHosted does not take effect #6247

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 21, 2024

No description provided.

Copy link

graphite-app bot commented Mar 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Contributor Author

fundon commented Mar 21, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 21, 2024

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.78%. Comparing base (9916cca) to head (64b09b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             beta    #6247      +/-   ##
==========================================
- Coverage   60.78%   60.78%   -0.01%     
==========================================
  Files         502      501       -1     
  Lines       22792    22791       -1     
  Branches     2018     2018              
==========================================
- Hits        13854    13853       -1     
  Misses       8709     8709              
  Partials      229      229              
Flag Coverage Δ
server-test 70.40% <ø> (ø)
unittest 39.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon requested a review from EYHN March 21, 2024 08:08
@fundon fundon marked this pull request as ready for review March 21, 2024 08:08
@Brooooooklyn Brooooooklyn self-requested a review March 21, 2024 08:08
@Brooooooklyn
Copy link
Member

need an additional fix for the canary branch, because the packages/core/.webpack dir isn't exist anymore on canary

@fundon
Copy link
Contributor Author

fundon commented Mar 21, 2024

need an additional fix for the canary branch, because the packages/core/.webpack dir isn't exist anymore on canary

I will check that and create an fix.

@fundon fundon changed the title fix(ci): isSelfHosted does not take effect under CI ci: fix isSelfHosted does not take effect Mar 21, 2024
@EYHN EYHN merged commit 62c603b into beta Mar 21, 2024
34 checks passed
@EYHN EYHN deleted the fix/03-21/isSelfHosted-does-not-take-effect-under-CI branch March 21, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants